empiredan commented on code in PR #1555:
URL:
https://github.com/apache/incubator-pegasus/pull/1555#discussion_r1249639606
##########
src/utils/test/metrics_test.cpp:
##########
@@ -3045,11 +3045,11 @@ TEST_P(MetricsRetirementTest, RetireOldMetrics)
}
const std::vector<surviving_metrics_case> metrics_retirement_tests = {
- {"server_117", true, true, true, true},
- {"server_118", true, true, true, false},
- {"server_119", true, true, false, false},
- {"server_120", true, false, false, false},
- {"server_121", false, false, false, false},
+ {std::string("server_117"), true, true, true, true},
Review Comment:
Does this fix https://github.com/apache/incubator-pegasus/issues/1424 for
ubuntu1604 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
