empiredan opened a new issue, #1587:
URL: https://github.com/apache/incubator-pegasus/issues/1587
There are some problems in current format string for logging and macro, such
as:
### Still use c-style format string, which would not print the correct
messages:
```c++
CHECK(false, "unsupported filter type: %d", filter_type);
```
### Call to-string method for the classes that have implement `operator<<`:
```c++
CHECK(!in_dropped,
"adjust position of existing node({}) failed, this is a
bug, partition({}.{})",
node.to_string(),
config_owner->pid.get_app_id(),
config_owner->pid.get_partition_index());
CHECK(false,
"we can't handle this when create backup policy, err({})",
err.to_string());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
