empiredan commented on code in PR #1667:
URL:
https://github.com/apache/incubator-pegasus/pull/1667#discussion_r1382775269
##########
src/replica/disk_cleaner.cpp:
##########
@@ -70,6 +75,91 @@ const std::string kFolderSuffixBak = ".bak";
const std::string kFolderSuffixOri = ".ori";
const std::string kFolderSuffixTmp = ".tmp";
+namespace {
+
+bool get_expiration_seconds_by_last_write_time(const std::string &path,
Review Comment:
OK, I'll replace all "expiration seconds” with "timestamp".
##########
src/replica/disk_cleaner.cpp:
##########
@@ -70,6 +75,91 @@ const std::string kFolderSuffixBak = ".bak";
const std::string kFolderSuffixOri = ".ori";
const std::string kFolderSuffixTmp = ".tmp";
+namespace {
+
+bool get_expiration_seconds_by_last_write_time(const std::string &path,
Review Comment:
OK, I'll replace all "expiration seconds” with "timestamp".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
