empiredan opened a new issue, #1761: URL: https://github.com/apache/incubator-pegasus/issues/1761
Compilation failed for go-collector as following messages: ``` go: downloading github.com/onsi/ginkgo v1.10.1 go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f go: downloading github.com/onsi/gomega v1.7.0 go: downloading github.com/mattn/go-isatty v0.0.12 go: downloading github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 go: downloading github.com/hpcloud/tail v1.0.0 go: downloading gopkg.in/tomb.v1 v1.0.0-2014[102](https://github.com/apache/incubator-pegasus/actions/runs/7137165426/job/19436733684?pr=1758#step:4:103)4135613-dd632973f1e7 go: downloading gopkg.in/fsnotify.v1 v1.4.7 go: downloading github.com/andybalholm/brotli v1.0.0 go: downloading github.com/valyala/bytebufferpool v1.0.0 go mod verify all modules verified go build -o collector # github.com/pegasus-kv/collector/avail Error: avail/detector.go:128:20: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) Error: avail/detector.go:133:37: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) Error: avail/detector.go:134:19: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) Error: avail/detector.go:139:38: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) make: *** [Makefile:21: build] Error 2 Error: Process completed with exit code 2. ``` and: ``` run golangci-lint Running [/home/runner/golangci-lint-1.29.0-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=./collector] in [/home/runner/work/incubator-pegasus/incubator-pegasus/collector] ... Error: level=warning msg="[runner] Can't run linter goanalysis_metalinter: bodyclose: failed prerequisites: [[email protected]/pegasus-kv/collector/avail: analysis skipped: errors in package: [/home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:1[28](https://github.com/apache/incubator-pegasus/actions/runs/7137165426/job/19436733856?pr=1758#step:4:30):21: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:133:38: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:134:20: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:139:39: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli)]]" Error: level=warning msg="[runner] Can't run linter unused: buildir: analysis skipped: errors in package: [/home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:128:21: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:133:38: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:134:20: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:139:39: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli)]" Error: level=error msg="Running error: buildir: analysis skipped: errors in package: [/home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:128:21: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:133:38: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:134:20: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli) /home/runner/work/incubator-pegasus/incubator-pegasus/collector/avail/detector.go:139:39: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli)]" Error: golangci-lint exit with code 3 Ran golangci-lint in 962ms ``` The reason is that `UnixMilli` was introduced in go version 1.17. We could upgrade the go version to 1.17 for the workflows on Github. Also, official document should be updated to tell the users what is the minimum go version that is supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
