acelyc111 commented on code in PR #1763:
URL:
https://github.com/apache/incubator-pegasus/pull/1763#discussion_r1423361109
##########
.github/workflows/build-push-env-docker.yml:
##########
@@ -62,6 +62,6 @@ jobs:
file: ./docker/pegasus-build-env/${{ matrix.dockertag }}/Dockerfile
push: true
tags: |
- apache/pegasus:build-env-${{ matrix.dockertag }}
+ apache/pegasus:build-env-${{ matrix.dockertag }}-${{
github.ref_name }}
Review Comment:
https://github.com/apache/incubator-pegasus/blob/71eae1b7a2ec37cb88ee0f8530859fbb4a1c0380/docker/thirdparties-src/Dockerfile
and
https://github.com/apache/incubator-pegasus/blob/71eae1b7a2ec37cb88ee0f8530859fbb4a1c0380/docker/thirdparties-bin/Dockerfile
are using images like apache/pegasus:build-env-centos7, you should also
consider this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
