acelyc111 commented on code in PR #1816:
URL:
https://github.com/apache/incubator-pegasus/pull/1816#discussion_r1435916035
##########
src/meta/meta_http_service.cpp:
##########
@@ -827,12 +828,26 @@ void meta_http_service::update_scenario_handler(const
http_request &req, http_re
bool meta_http_service::redirect_if_not_primary(const http_request &req,
http_response &resp)
{
-#ifdef DSN_MOCK_TEST
- return true;
+#ifdef MOCK_TEST
+ // Once MOCK_TEST is defined, the meta server must has been built with
`./run.sh build --test`.
Review Comment:
It would be better to say `BUILD_TEST` or `MOCK_TEST` is enabled, because
it's possible to build by cmake directly, not using ./run.sh build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
