acelyc111 commented on code in PR #1826:
URL:
https://github.com/apache/incubator-pegasus/pull/1826#discussion_r1445701140
##########
collector/config.yml:
##########
@@ -25,7 +25,7 @@ meta_servers:
- 127.0.0.1:34603
# local server port
-port : 34101
+port : 8081
Review Comment:
8080, 8081 are widely used ports for web servers, it would be better to use
34101 to keep compatible (old version of collectors may have been used by
communituy users, don't change the behavior).
##########
collector/webui/webserver.go:
##########
@@ -53,9 +57,25 @@ func StartWebServer() {
app.RegisterView(tmpl)
go func() {
- err := app.Listen(":8080")
+ localPort := ":" + viper.GetString("port")
+ err := app.Listen(localPort)
if err != nil {
return
}
}()
+
+ //Provide metrics for prometheus
Review Comment:
```suggestion
// Provide metrics for Prometheus.
```
##########
collector/config.yml:
##########
@@ -34,7 +34,7 @@ metrics:
prometheus:
# the exposed port for prometheus exposer
- exposer_port : 1111
+ exposer_port : 8080
Review Comment:
Same, and 34*01 ports are used by Pegasus by habit, how about use 34201
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
