empiredan commented on code in PR #1843:
URL:
https://github.com/apache/incubator-pegasus/pull/1843#discussion_r1454708640
##########
src/http/test/http_client_test.cpp:
##########
@@ -32,10 +33,108 @@
#include "utils/error_code.h"
#include "utils/errors.h"
#include "utils/fmt_logging.h"
+#include "utils/strings.h"
#include "utils/test_macros.h"
namespace dsn {
+using http_url_case =
+ std::tuple<const char *, const char *, uint16_t, const char *, const char
*, const char *>;
Review Comment:
Good idea, I've used `struct` for all of the cases that need many arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
