empiredan commented on code in PR #1861:
URL:
https://github.com/apache/incubator-pegasus/pull/1861#discussion_r1458308626
##########
collector/main.go:
##########
@@ -98,4 +99,6 @@ func main() {
return metrics.NewReplicaServerMetricCollector().Start(tom)
})
<-tom.Dead() // gracefully wait until all goroutines dead
+
+ webui.StartWebServer(registry)
Review Comment:
Should this be put before `tom`, otherwise this would never be called ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
