Re: [PR] feat: Support meta_server connect to Kerberos sasl authenticated Zookeeper where KDC configured 'rdns = false' [incubator-pegasus]

Mon, 22 Jan 2024 18:35:11 -0800 


GehaFearless commented on code in PR #1864:
URL: 
https://github.com/apache/incubator-pegasus/pull/1864#discussion_r1462657897


##########
src/zookeeper/zookeeper_session.cpp:
##########
@@ -161,6 +166,11 @@ int zookeeper_session::attach(void *callback_owner, const 
state_callback &cb)
             zoo_sasl_params_t sasl_params = {0};
             sasl_params.service = 
dsn::security::FLAGS_zookeeper_kerberos_service_name;
             sasl_params.mechlist = "GSSAPI";
+            rpc_address addr;
+            
CHECK(addr.from_string_ipv4(dsn::security::FLAGS_zookeeper_sasl_service_fqdn),

Review Comment:
   
![image](https://github.com/apache/incubator-pegasus/assets/48315319/34fb9315-6909-4c3d-983f-8e90dc8e1dbc)
   



##########
src/zookeeper/zookeeper_session.cpp:
##########
@@ -43,6 +44,10 @@ DSN_DEFINE_string(security,
                   zookeeper_kerberos_service_name,
                   "zookeeper",
                   "zookeeper kerberos service name");
+DSN_DEFINE_string(security,
+                  zookeeper_sasl_service_fqdn,
+                  "",
+                  "The fqdn of sasl server name which one connect to zookeeper 
service");

Review Comment:
   
![image](https://github.com/apache/incubator-pegasus/assets/48315319/c02f72c9-3dc0-4c66-aa3c-9a7fce6bd56c)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to