GehaFearless commented on code in PR #1658:
URL: 
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1474031234


##########
idl/partition_split.thrift:
##########
@@ -112,10 +113,11 @@ struct notify_cacth_up_response
 // primary parent -> child replicas to update partition count
 struct update_child_group_partition_count_request
 {
-    1:dsn.rpc_address   target_address;
+    1:dsn.rpc_address   target;

Review Comment:
   shouldn't be backward compatible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to