acelyc111 commented on code in PR #1608:
URL:
https://github.com/apache/incubator-pegasus/pull/1608#discussion_r1481265241
##########
src/replica/duplication/duplication_sync_timer.cpp:
##########
@@ -211,5 +232,14 @@ duplication_sync_timer::get_dup_states(int app_id, /*out*/
bool *app_found)
return result;
}
+bool duplication_sync_timer::replica_is_cloing_or_closed(gpid id)
+{
+ if (_stub->_closing_replicas.find(id) != _stub->_closing_replicas.end() ||
Review Comment:
> I think it's possible to judge the replica's state by itself, maybe by
`status()`, it's not needed to access replica_stub.
@ninsmiracle take a look at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
