acelyc111 commented on code in PR #1897:
URL:
https://github.com/apache/incubator-pegasus/pull/1897#discussion_r1497388259
##########
src/common/json_helper.h:
##########
@@ -421,7 +421,9 @@ inline bool json_decode(const dsn::json::JsonObject &in,
dsn::rpc_address &addre
if (rpc_address_string == "invalid address") {
return true;
}
- return address.from_string_ipv4(rpc_address_string.c_str());
+
+ address = dsn::rpc_address::from_host_port(rpc_address_string);
+ return !address.is_invalid();
Review Comment:
It would be more readability to keep the code style IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
