acelyc111 commented on code in PR #1908: URL: https://github.com/apache/incubator-pegasus/pull/1908#discussion_r1522480693
########## src/common/duplication_common.h: ########## @@ -31,6 +31,7 @@ #include "utils/fmt_utils.h" DSN_DECLARE_uint32(duplicate_log_batch_bytes); +DSN_DECLARE_bool(force_send_no_idempotent_when_duplication); Review Comment: The DSN_DECLARE_xxx macros are recommended to move to cpp files where actually use it, don't make the header files to be too large. The same to `DSN_DECLARE_uint32(duplicate_log_batch_bytes); ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
