empiredan commented on code in PR #1841:
URL:
https://github.com/apache/incubator-pegasus/pull/1841#discussion_r1540951949
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -234,7 +242,8 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
batch_bytes += raw_message.length();
}
- if (batch_count == muts.size() || batch_bytes >=
FLAGS_duplicate_log_batch_bytes) {
+ if (batch_count == muts.size() || batch_bytes >=
FLAGS_duplicate_log_batch_bytes ||
+ batch_bytes >= dsn::replication::FLAGS_dup_max_allowed_write_size)
{
Review Comment:
Actually `dup_max_allowed_write_size` of master cluster relates to
`max_allowed_write_size` of follower cluster. Once requests are rejected by
follower cluster, `max_allowed_write_size` of follower cluster needs to be
increased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
