acelyc111 commented on code in PR #1954: URL: https://github.com/apache/incubator-pegasus/pull/1954#discussion_r1562366636
########## src/runtime/test/dns_resolver_test.cpp: ########## @@ -0,0 +1,78 @@ +/* Review Comment: Not suitable, I separated it intentionally. This file is aimed to test class dns_resolver, while host_port_test.cpp is aimed to test class host_port. I Separated them to clarify the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
