acelyc111 commented on code in PR #1949:
URL:
https://github.com/apache/incubator-pegasus/pull/1949#discussion_r1566624345
##########
idl/bulk_load.thrift:
##########
@@ -91,7 +91,7 @@ struct bulk_load_request
{
1:dsn.gpid pid;
2:string app_name;
- 3:dsn.rpc_address primary_addr;
+ 3:dsn.rpc_address primary;
Review Comment:
In some newly added macros, they suppose the rpc_address and host_port
fields are naming similarly with name `xxx` and `hp_xxx`. The macros are
helpful to ensure the operations are taken both on the 2 fields. So I rename it.
Rename the thrift structure fileds dosen't break compatibility if not change
the sequence number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
