acelyc111 commented on code in PR #2159:
URL:
https://github.com/apache/incubator-pegasus/pull/2159#discussion_r1865477427
##########
src/meta/duplication/duplication_info.cpp:
##########
@@ -20,10 +20,20 @@
#include "common/duplication_common.h"
#include "meta/meta_data.h"
#include "runtime/api_layer1.h"
+#include "utils/flags.h"
#include "utils/fmt_logging.h"
-namespace dsn {
-namespace replication {
+DSN_DEFINE_uint64(replication,
+ dup_progress_min_update_period_ms,
+ 5000,
+ "The minimum period in milliseconds that progress of
duplication is updated");
+
+DSN_DEFINE_uint64(replication,
+ dup_progress_min_report_period_ms,
+ static_cast<uint64_t>(5) * 60 * 1000,
Review Comment:
Why add static cast? It this OK?
```suggestion
5ULL * 60 * 1000,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
