acelyc111 commented on code in PR #2167:
URL:
https://github.com/apache/incubator-pegasus/pull/2167#discussion_r1883165754
##########
src/shell/commands/duplication.cpp:
##########
@@ -135,12 +135,13 @@ void attach_dups_stat(const list_dups_stat &stat,
dsn::utils::multi_table_printe
printer.add_row_name_and_data("unfinished_app_count",
stat.unfinished_app_count);
// Add stats for duplications.
- printer.add_row_name_and_data("duplication_count", stat.duplication_count);
+ printer.add_row_name_and_data("total_duplication_count",
stat.duplication_count);
for (const auto &[status, cnt] : stat.dup_status_stats) {
- printer.add_row_name_and_data(fmt::format("{}_count", status), cnt);
+
printer.add_row_name_and_data(fmt::format("duplication_count_by_status({})",
status), cnt);
}
for (const auto &[remote_cluster, cnt] : stat.dup_remote_cluster_stats) {
- printer.add_row_name_and_data(fmt::format("{}_count", remote_cluster),
cnt);
+ printer.add_row_name_and_data(
+ fmt::format("duplication_count_by_follower_cluster({})",
remote_cluster), cnt);
Review Comment:
Are the row names are too long, the displayed table row may be too wide and
hard to be filled on screen ?
Could you please give a sampe output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
