acelyc111 commented on code in PR #2192:
URL:
https://github.com/apache/incubator-pegasus/pull/2192#discussion_r1954705187
##########
src/server/pegasus_write_service.cpp:
##########
@@ -326,7 +375,7 @@ void pegasus_write_service::set_default_ttl(uint32_t ttl) {
_impl->set_default_t
void pegasus_write_service::clear_up_batch_states()
Review Comment:
The function name is not accurate, not only 'clean up', but also update the
metrics.
##########
src/server/pegasus_write_service.h:
##########
@@ -202,6 +216,12 @@ class pegasus_write_service :
dsn::replication::replica_base
uint64_t _batch_start_time;
+ // Only used for primary replica to calculate the duration that an incr
request from
+ // the client is translated into an idempotent put request before appended
to plog,
+ // including reading the current value from RocksDB and incrementing it by
a given
+ // amount.
+ uint64_t _make_incr_idempotent_duration_ns;
Review Comment:
This is a member variable, which will be shared by all requests. But it's a
request related latency, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
