Samunroyu commented on code in PR #1994:
URL:
https://github.com/apache/incubator-pegasus/pull/1994#discussion_r1986507814
##########
src/rpc/rpc_host_port.h:
##########
@@ -232,6 +232,14 @@ class TProtocol;
DCHECK_EQ(_obj.field.size(), _obj.hp_##field.size());
\
} while (0)
+#define REMOVE_IP_AND_HOST_PORT(dst_obj, dst_field, to_rm_addr, to_rm_hp)
\
Review Comment:
Should the parameter order of this macro definition be adjusted to be
consistent with the parameter order of the remove_node function()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
