Samunroyu commented on code in PR #2049:
URL:
https://github.com/apache/incubator-pegasus/pull/2049#discussion_r1992517093
##########
src/replica/replica_config.cpp:
##########
@@ -191,15 +192,24 @@ void replica::add_potential_secondary(const
configuration_update_request &propos
CHECK_EQ(proposal.config.ballot, get_ballot());
CHECK_EQ(proposal.config.pid, _primary_states.pc.pid);
- CHECK_EQ(proposal.config.hp_primary, _primary_states.pc.hp_primary);
- CHECK(proposal.config.hp_secondaries == _primary_states.pc.hp_secondaries,
"");
-
+ CHECK_EQ(proposal.config.primary, _primary_states.pc.primary);
Review Comment:
why funct add_potnetial_secondary need to check rpc_address of
proposal.config.primary equal to _primary_states.pc.primary?
And func downgrade_to_secondary_on_primary is not check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
