acelyc111 commented on code in PR #2205:
URL:
https://github.com/apache/incubator-pegasus/pull/2205#discussion_r1997484444
##########
src/meta/meta_service.h:
##########
@@ -289,6 +289,12 @@ class meta_service : public serverlet<meta_service>
void on_get_max_replica_count(configuration_get_max_replica_count_rpc rpc);
void on_set_max_replica_count(configuration_set_max_replica_count_rpc rpc);
+ // Get `atomic_idempotent` of an table.
+ void on_get_atomic_idempotent(configuration_get_atomic_idempotent_rpc rpc);
+
+ // Set `atomic_idempotent` of an table.
Review Comment:
```suggestion
// Set `atomic_idempotent` of a table.
```
##########
src/meta/server_state.h:
##########
@@ -200,6 +203,12 @@ class server_state
void set_max_replica_count(configuration_set_max_replica_count_rpc rpc);
void recover_from_max_replica_count_env();
+ // Get `atomic_idempotent` of an table.
+ void get_atomic_idempotent(configuration_get_atomic_idempotent_rpc rpc)
const;
+
+ // Set `atomic_idempotent` of an table.
Review Comment:
```suggestion
// Set `atomic_idempotent` of a table.
```
##########
src/meta/meta_service.h:
##########
@@ -289,6 +289,12 @@ class meta_service : public serverlet<meta_service>
void on_get_max_replica_count(configuration_get_max_replica_count_rpc rpc);
void on_set_max_replica_count(configuration_set_max_replica_count_rpc rpc);
+ // Get `atomic_idempotent` of an table.
Review Comment:
```suggestion
// Get `atomic_idempotent` of a table.
```
##########
src/meta/server_state.h:
##########
@@ -200,6 +203,12 @@ class server_state
void set_max_replica_count(configuration_set_max_replica_count_rpc rpc);
void recover_from_max_replica_count_env();
+ // Get `atomic_idempotent` of an table.
Review Comment:
```suggestion
// Get `atomic_idempotent` of a table.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
