acelyc111 commented on code in PR #2206: URL: https://github.com/apache/incubator-pegasus/pull/2206#discussion_r2003606642
########## .gitignore: ########## @@ -350,3 +350,38 @@ thirdparty/output/ #collector collector/collector + +# ================= # +# pegasus-spark # +# ================= # +pegasus-spark/*.class +# Log file +pegasus-spark/*.log Review Comment: It would be nice it keep them in lexicographical order, thanks! ########## pegasus-spark/.travis.yml: ########## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I think this file is useless because we dodn't use Travis for CI, instead, we use Github actions. ########## pegasus-spark/pom.xml: ########## @@ -0,0 +1,252 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>com.xiaomi.infra</groupId> + <artifactId>pegasus-spark</artifactId> + <version>1.1.0-mdh-2.3.0-SNAPSHOT</version> Review Comment: Use a completely new version because it's in a new group. ########## pegasus-spark/pom.xml: ########## @@ -0,0 +1,252 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>com.xiaomi.infra</groupId> + <artifactId>pegasus-spark</artifactId> + <version>1.1.0-mdh-2.3.0-SNAPSHOT</version> + + <name>pegasus-spark</name> + + <distributionManagement> + <repository> + <id>central</id> + <name>maven-release-virtual</name> + <url>https://pkgs.d.xiaomi.net/artifactory/maven-release-virtual</url> + </repository> + <snapshotRepository> + <id>snapshots</id> + <name>maven-snapshot-virtual</name> + <url>https://pkgs.d.xiaomi.net/artifactory/maven-snapshot-virtual</url> + </snapshotRepository> + </distributionManagement> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>1.8</maven.compiler.source> + <maven.compiler.target>1.8</maven.compiler.target> + <pegasus.shade.name>com.xiaomi.infra.pegasus.spark.thirdparty</pegasus.shade.name> + </properties> + + <dependencies> + <dependency> + <groupId>junit</groupId> + <artifactId>junit</artifactId> + <version>4.13.1</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.github.rholder</groupId> + <artifactId>guava-retrying</artifactId> + <version>2.0.0</version> + </dependency> + <dependency> + <groupId>commons-cli</groupId> + <artifactId>commons-cli</artifactId> + <version>1.4</version> + </dependency> + <dependency> + <groupId>org.apache.commons</groupId> + <artifactId>commons-lang3</artifactId> + <version>3.8.1</version> + </dependency> + <dependency> + <groupId>commons-configuration</groupId> + <artifactId>commons-configuration</artifactId> + <version>1.8</version> + </dependency> + <dependency> + <groupId>commons-beanutils</groupId> + <artifactId>commons-beanutils</artifactId> + <version>1.8.0</version> + </dependency> + <dependency> + <groupId>commons-jxpath</groupId> + <artifactId>commons-jxpath</artifactId> + <version>1.3</version> + </dependency> + <dependency> + <groupId>com.typesafe</groupId> + <artifactId>config</artifactId> + <version>1.4.0</version> + </dependency> + <dependency> + <groupId>com.google.code.gson</groupId> + <artifactId>gson</artifactId> + <version>2.8.6</version> + </dependency> + <dependency> + <groupId>com.revinate</groupId> + <artifactId>guava-rate-limiter</artifactId> + <version>19.0</version> + </dependency> + <dependency> + <groupId>org.rocksdb</groupId> + <artifactId>rocksdbjni</artifactId> + <version>6.6.4-SNAPSHOT</version> + </dependency> + + <!--Pegasus: The version add `Serializable` for some class, it will be replaced by release version--> + <dependency> + <groupId>com.xiaomi.infra</groupId> + <artifactId>pegasus-client</artifactId> + <version>1.11.10-for-spark-SNAPSHOT</version> + <exclusions> + <exclusion> + <groupId>io.netty</groupId> + <artifactId>netty-all</artifactId> + </exclusion> + </exclusions> + </dependency> + <!--FDS: Only read fds backup need the dependency--> Review Comment: Let's implement the HDFS target at first, because most users can not use FDS. ########## pegasus-spark/scripts/travis.sh: ########## @@ -0,0 +1,43 @@ +#!/usr/bin/env bash Review Comment: Please use Github action instead, thanks! ########## README.md: ########## @@ -76,6 +76,7 @@ Pegasus has support for several languages: - [Python](https://github.com/apache/incubator-pegasus/blob/master/python-client) - [Node.js](https://github.com/apache/incubator-pegasus/blob/master/nodejs-client) - [Scala](https://github.com/apache/incubator-pegasus/blob/master/scala-client) +- [pegasus-spark](https://github.com/apache/incubator-pegasus/blob/master/pegasus-spark) Review Comment: Is pegasus-spark a client driver? Move it to another section if it's not. ########## pegasus-spark/pom.xml: ########## @@ -0,0 +1,252 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>com.xiaomi.infra</groupId> Review Comment: Update it to org.apache.... ########## pegasus-spark/pom.xml: ########## @@ -0,0 +1,252 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>com.xiaomi.infra</groupId> + <artifactId>pegasus-spark</artifactId> + <version>1.1.0-mdh-2.3.0-SNAPSHOT</version> + + <name>pegasus-spark</name> + + <distributionManagement> + <repository> + <id>central</id> + <name>maven-release-virtual</name> + <url>https://pkgs.d.xiaomi.net/artifactory/maven-release-virtual</url> Review Comment: Don't use xiaomi any more. ########## pegasus-spark/scripts/format-all.sh: ########## @@ -0,0 +1,52 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +SCRIPT_DIR=$(dirname "${BASH_SOURCE[0]}") +PROJECT_DIR=$(dirname "${SCRIPT_DIR}") +cd "${PROJECT_DIR}" || exit 1 + +SRC_FILES=(src/main/java/com/xiaomi/infra/pegasus/spark/common/*.java Review Comment: update the paths to org/apache/pegasus/... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
