acelyc111 commented on code in PR #2217:
URL:
https://github.com/apache/incubator-pegasus/pull/2217#discussion_r2055923368
##########
src/replica/replica_context.cpp:
##########
@@ -133,11 +133,17 @@ void
primary_context::get_replica_config(partition_status::type st,
bool primary_context::check_exist(const ::dsn::host_port &node,
partition_status::type st)
{
+ host_port primary;
+ std::vector<host_port> secondaries;
+ GET_HOST_PORT(pc, primary, primary);
+ GET_HOST_PORTS(pc, secondaries, secondaries);
switch (st) {
case partition_status::PS_PRIMARY:
- return pc.hp_primary == node;
+ // DCHECK(pc.__isset.hp_primary, "");
Review Comment:
Why commented this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
