empiredan commented on code in PR #2238: URL: https://github.com/apache/incubator-pegasus/pull/2238#discussion_r2066122945
########## src/test_util/test_util.h: ########## @@ -92,6 +93,10 @@ class stop_watch void create_local_test_file(const std::string &full_name, dsn::replication::file_meta *fm); +// Generate a file under `file_path` with size `file_size`. The file is filled with +// `file_size` 'a's. +void generate_test_file(const std::string &file_path, int64_t file_size); Review Comment: OK, I'll implement a class managing the file's life cycle with RAII. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
