empiredan commented on code in PR #2259:
URL:
https://github.com/apache/incubator-pegasus/pull/2259#discussion_r2144278907
##########
src/ranger/ranger_resource_policy_manager.cpp:
##########
@@ -206,7 +208,12 @@
ranger_resource_policy_manager::ranger_resource_policy_manager(
void ranger_resource_policy_manager::start()
{
- CHECK_NOTNULL(_meta_svc, "");
+ if (_meta_svc == nullptr) {
+ // `_meta_svc` being null implies that the policies will be updated
manually,
Review Comment:
Yes, it's only used for test. I'll add `MOCK_TEST` macro to control it. Do
not use `NDEBUG` since tests running on Github are built with `Release` rather
than `Debug`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
