empiredan commented on code in PR #2261:
URL:
https://github.com/apache/incubator-pegasus/pull/2261#discussion_r2160936054
##########
src/rpc/rpc_holder.h:
##########
@@ -224,9 +224,13 @@ class rpc_holder
dsn_rpc_forward(dsn_request(), addr);
}
- inline void set_auto_reply(bool auto_reply) { _i->auto_reply = auto_reply;
}
+ [[nodiscard]] inline bool is_auto_reply() const { return _i->auto_reply; }
- inline void enable_auto_reply() { set_auto_reply(true); }
+ inline void set_auto_reply(bool auto_reply) const { _i->auto_reply =
auto_reply; }
Review Comment:
Yes, currently we've never called `set_auto_reply()` externally. So it could
be made private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
