lengyuexuexuan commented on code in PR #2285:
URL: 
https://github.com/apache/incubator-pegasus/pull/2285#discussion_r2296968313


##########
go-client/config/config.go:
##########
@@ -17,9 +17,15 @@
  * under the License.
  */
 
-package pegasus
+package config
 
 // Config is the configuration of pegasus client.
 type Config struct {
-       MetaServers []string `json:"meta_servers"`
+       MetaServers      []string          `json:"meta_servers"`
+       PerfCounterTags  map[string]string `json:"perf_counter_tags"`
+       EnableFalcon     bool              `json:"enable_falcon"`
+       EnablePrometheus bool              `json:"enable_prometheus"`
+       FalconServer     string            `json:"falcon_server"`
+       FalconInterval   int               `json:"falcon_interval_secs"`
+       PrometheusPort   int               `json:"prometheus_port"`

Review Comment:
   Is a default config necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to