Samunroyu commented on code in PR #2341:
URL:
https://github.com/apache/incubator-pegasus/pull/2341#discussion_r2672324584
##########
thirdparty/CMakeLists.txt:
##########
@@ -119,23 +129,30 @@ ExternalProject_Add(gperftools
DOWNLOAD_NO_PROGRESS true
)
+
+set(ABSL_OPTIONS
+ -DCMAKE_INSTALL_PREFIX=${TP_OUTPUT}
+ -DCMAKE_POSITION_INDEPENDENT_CODE=ON
+ -DABSL_FIND_GOOGLETEST=OFF
+ -DCMAKE_CXX_STANDARD=17
+)
+
+if (ENABLE_ASAN)
+ list(APPEND ABSL_OPTIONS ${ASAN_OPTIONS})
+endif()
+
ExternalProject_Add(abseil
URL ${OSS_URL_PREFIX}/abseil-20230802.1.zip
https://github.com/abseil/abseil-cpp/archive/refs/tags/20230802.1.zip
Review Comment:
So this issue is because we didn't distinguish between Asan and non-Asan
modes when compiling Abseil, rather than being a problem with Abseil itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
