mdedetrich commented on code in PR #2:
URL: https://github.com/apache/incubator-pekko/pull/2#discussion_r1012655665
##########
.scalafmt.conf:
##########
@@ -1,21 +1,52 @@
-version = 2.1.0
-
-style = defaultWithAlign
-
-docstrings = JavaDoc
-indentOperator = spray
-maxColumn = 120
-lineEndings = preserve
-rewrite.rules = [RedundantParens, SortImports, AvoidInfix]
-unindentTopLevelOperators = true
-align.tokens = [{code = "=>", owner = "Case"}]
-align.openParenDefnSite = false
-align.openParenCallSite = false
-optIn.breakChainOnFirstMethodDot = false
-optIn.configStyleArguments = false
-danglingParentheses = false
-spaces.inImportCurlyBraces = true
-rewrite.neverInfix.excludeFilters = [
+version = 3.6.1
+runner.dialect = scala213
+project.git = true
+style = defaultWithAlign
+docstrings.style = Asterisk
+docstrings.wrap = false
+indentOperator.preset = spray
+maxColumn = 120
Review Comment:
On final thought I will resolve this conversation, changing the value from
120 is massively detrimental to the PR's goals of trying to minimize the diff.
If we are going to change this, it would be on the alternative approach
where instead of minimizing the diff we instead just try to use a more standard
scalafmt configuration accepting that the diff would be massive, i.e.
https://github.com/mdedetrich/akka-apache/pull/2#issuecomment-1291044281 .
If people want to entertain this then we can do a github discussions poll
(once its enabled) to gauge whether the community at large would prefer that
path and then one can always create a formal apache vote for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
