So I believe the general community agreement is that the first release of Pekko and any of its modules is the minimum necessary changes to get it released (ideally this is just change of packages but for the Pekko core project this is not so trivial as we have seen).
Then there is going to be another release (with a bumped major version) where changes go in as long as they don't break backwards compatibility. I am not sure if the Scala3 changes for akka-http broke binary compatibility, but if they didn't then even if the changes are disruptive to the source code I don't see this being problematic for such a release. On Thu, Nov 3, 2022 at 11:08 AM Johannes Rudolph <[email protected]> wrote: > Hi, > > for pekko-http, we need to think about how to approach the first few > changes. We should do: > > * integrate the Scala 3 branch that was not yet released > * move from scalariform to scalafmt > * new package names > > Originally, the Scala 3 branch was not yet merged (and therefore > missed 10.2.10) because it does not mix all to well with Scala 2.12 > support. It works but it requires some hacky patching of source files > to remove some code that cannot be compiled on all targets (we tried > to avoid version-dependent source files especially here since it > touches the biggest source file, headers.scala, and we have had many > bad experiences with bugs in versioned forks of source files). > > At this point I would probably just merge the existing Scala 3 branch > to ensure this work is not lost even if it adds complexity to the > build. The hope would be that we might be able to drop Scala 2.12 soon > after the first release to clean things up. > > In general, it goes somewhat against the goal of not adding any > changes in the first version of pekko but doing the merge later on > will be quite painful. > > If you agree, we should try to do the changes in the order as shown above. > > (Obviously, we should use the state of the scala-3 branch before the > license change. Afterwards, a merge from main was added containing the > license change.) > > WDYT? > Johannes > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
