jrudolph commented on code in PR #4:
URL:
https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015251126
##########
.github/workflows/nightly.yml:
##########
@@ -44,8 +44,9 @@ jobs:
- name: Compile everything
run: sbt -Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }}
++${{ matrix.SCALA_VERSION }} Test/compile
+ # mima checks have been temporarily removed
- name: Run all tests JDK ${{ matrix.JABBA_JDK }}, Scala ${{
matrix.SCALA_VERSION }}, Akka ${{ matrix.AKKA_VERSION }}
- run: sbt -Dakka.http.parallelExecution=false -Dakka.test.timefactor=2
-Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{
matrix.SCALA_VERSION }} mimaReportBinaryIssues test
+ run: sbt -Dakka.http.parallelExecution=false -Dakka.test.timefactor=2
-Dakka.http.build.akka.version=${{ matrix.AKKA_VERSION }} ++${{
matrix.SCALA_VERSION }} test
Review Comment:
We might be able to keep them here (and below) now as well, since they
should be a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
