Seems ok to me. On Fri 10 Mar 2023, 13:57 Matthew Benedict de Detrich, <[email protected]> wrote:
> During discourse in https://github.com/apache/incubator-pekko/issues/130 > it > was revealed that our release strategy doesn't fall in line with how > sbt-ci-release is designed. This is largely because sbt-ci-release's > primary mechanism for making a release is by pushing a git tag and this > doesn't follow well with ASF's release policies. Furthermore when it comes > to SNAPSHOT's, this is not triggered by pushing a git tag but rather in > either a nightly job or after a PR merge from main branch and such jobs use > the standard sbt publish command. > > Due to these reasons, the sbt-ci-release plugin is at best pointless and at > worst arguably misleading. We are not going to be using ci-release command > and the only useful functionality we are getting from sbt-ci-release right > now is it transitively bringing in the sbt-dynver dependency along with > setting dynverSonatypeSnapshots := true. > > My suggestion would be to remove sbt-ci-release from our Pekko projects and > instead just use sbt-dynver directly, along with setting the > dynverSonatypeSnapshots := true directly (since this is just a single line > its not a lot of boilerplate and arguably the explicit clarity here is > beneficial). There was an issue with sbt-apache-sonatype which didn't set > publishTo that caused confusion (we ended up relying sbt-ci-release setting > publishTo implicitly) however this has since been solved in the 0.1.6 > release (see https://github.com/mdedetrich/sbt-apache-sonatype/pull/10). > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* [email protected] >
