I have broad agreement with this. My impressions/understanding of the Incubator process is they are less concerned of the ultimate outcome of what we do with the 3rd party code on a case by case basis (and in a lot of cases what we should do is actually not clear as has already been shown) but rather the fact that we have accounted, in some way, for every piece of 3rd party code in some way (i.e. as a bare minimum that it's mentioned in LICENSE). To put it differently, there is a massive difference between having 3rd party code with no disclaimer whatsoever (i.e. some mention in LICENSE) vs it being mentioned even if not entirely correct because the latter at least demonstrates that due diligence was attempted (and it's this that matters the most).
Creating an issue for each of these instances of 3rd party code with a specified github tag will go a long way in helping achieve this outcome and I also suspect this would improve confidence for the Incubator PMC. On Tue, Jun 20, 2023 at 3:01 PM PJ Fanning <[email protected]> wrote: > Hi everyone, > > Our biggest blocker to proceeding to a Pekko release is now all the > open questions about 3rd party source code that is in the main git > repo [1]. > > I have added a 'licensing' label to all the GitHub issues and PRs that > I found related to this [2]. > > There may be a few more issues to open yet. > > At the moment, Incubator PMC members are searching our code, looking > for GitHub URLs and strings like 'based on' in comments. I'm going to > suggest that we add comments along side any of these comments and have > a 2nd link that links to the GitHub issue that discusses that code and > the decisions that have been made. There are often differences in > interpretation about how the 3rd party code should be treated. These > relate to what license headers that should appear in the source files > and how the code should be mentioned in our project LICENSE and NOTICE > file(s). > > I think adding the links in our code to the discussions is a good way > to simplify the task of reviewing the release candidates. > > I would be interested in everyone's opinion. If anyone doesn't like > the idea of adding extra comments to our code, could they suggest > alternatives? > > > > [1] https://github.com/apache/incubator-pekko > [2] https://github.com/apache/incubator-pekko/issues?q=label%3Alicensing > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
