Ah, it's about http-cors not http-core :) I remember the discussion and the problem. I agree it would be a good addition but maybe not a hard blocker for a release of pekko-http or pekko-grpc. We can find ways that keeps it out of the critical path for now.
On Thu, Jun 29, 2023 at 10:13 AM Matthew Benedict de Detrich <[email protected]> wrote: > > > what is that about and has it been discussed somewhere? > > This has been discussed before, main conversation is at > https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy and there > is also an upstream issue at > https://github.com/lomigmegard/pekko-http-cors/issues/33. > > The tl;dr is that currently pekko-http-cors forms a diamond dependency > problem (something that wasn't a concern when it was created which was > before akka-grpc even existed) and since cors is part of the W3C standard > it makes sense for it to be part of pekko-http (alongside that its ultra > stable and hasn't really changed so it's not really going to add > maintenance burden) > > On Thu, Jun 29, 2023 at 9:38 AM Johannes Rudolph <[email protected]> > wrote: > > > On Wed, Jun 28, 2023 at 8:00 PM Matthew Benedict de Detrich > > <[email protected]> wrote: > > > The only thing I feel strongly about is the addition of the > > pekko-http-core > > > module to pekko-http in order to remove the diamond dependency. > > > > Hi Matthew, > > > > what is that about and has it been discussed somewhere? > > > > Johannes > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
