In addition to my last post in confirming the build is okay when using sbt-reproducible-build, I just checked detached signatures to confirm that the JVM jars are properly signed. I have also updated https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#build-the-source-release-candidate to mention that you need to clean the project since sbt's incremental compiler is not deterministic if compiled JVM bytecode already exists.
+1 from me On Tue, Jul 25, 2023 at 9:21 AM Matthew de Detrich < [email protected]> wrote: > Apologies with jardiff, as pointed out I was comparing the wrong jar's and > when done correctly there doesn't appear to be any bytecode difference. > Interestingly since I had to do a publishLocal in order to compare the > jardiff the sha512's now appear to be correct on my local machine so it > seems like I may have had bad state (due to not cleaning beforehand), i.e. > > <~/pekko-release-check-jars>-> sha512sum > ~/.ivy2/local/org.apache.pekko/pekko-remote_2.12/1.0.1/jars/pekko-remote_2.12.jar > 316e5366cb654e76afc054fc48d18b19784fa1e671e3cd455900aff3ac923867e85e6057755430d8b3b11ef7905b6d4b2f5c1fccb8eea2cee7ab2cb27005ad75 > > /Users/mdedetrich/.ivy2/local/org.apache.pekko/pekko-remote_2.12/1.0.1/jars/pekko-remote_2.12.jar > > <~/pekko-release-check-jars>-> sha512sum > ~/pekko-release-check-jars/pekko-remote_2.12-1.0.1.jar > 316e5366cb654e76afc054fc48d18b19784fa1e671e3cd455900aff3ac923867e85e6057755430d8b3b11ef7905b6d4b2f5c1fccb8eea2cee7ab2cb27005ad75 > /Users/mdedetrich/pekko-release-check-jars/pekko-remote_2.12-1.0.1.jar > > So I went ahead and ran sbt +clean , re-ran sbt-reproducible build and I > can confirm that everything is okay now > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/pekko-remote_2.12/1.0.1/pekko-remote_2.12-1.0.1.pom > [info] # `pekko-remote_2.12-1.0.1.buildinfo`: OK > [info] > [info] - pekko-remote_2.12-1.0.1.jar: Match > [info] - pekko-remote_2.12-1.0.1.pom: Match > > This was a false alarm on my part, apologies > > On Tue, Jul 25, 2023 at 9:09 AM Johannes Rudolph < > [email protected]> wrote: > >> On Tue, Jul 25, 2023 at 9:02 AM Matthew de Detrich >> <[email protected]> wrote: >> > jardiff -g ~/github/diff-temp/ >> > >> ~/.ivy2/local/org.apache.pekko/pekko-remote_2.12/1.0.0/jars/pekko-remote_2.12.jar >> > ~/pekko-release-check-jars/pekko-remote_2.12-1.0.1.jar >> >> Here you compare 1.0.0 vs 1.0.1. >> >> Not sure about the other binary differences, though. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* [email protected] > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
