I'd vote for merging the Scala 3 support we already have so we can continue on downstream projects like pekko-persistence-cassandra and have their initial release with Scala 3 support. People relying on connectors without Scala 3 can continue to use the 2.13 builds as they do currently until we can provide support.
On Mon, 14 Aug 2023 at 14:59, PJ Fanning <[email protected]> wrote: > Hi everyone, > > I would really appreciate community feedback on this topic. We need more > voices to be heard. > > Not merging the scala3 work for pekko-connectors means: > > * it will delay us from doing a pekko-connectors 1.0.0 release - or we end > up releasing pekko-connectors 1.0.0 without any Scala 3 support > * not merging it is already delaying us from adding Scala 3 support to > modules like pekko-persistence-cassandra > * it's already a bit of pain to regularly rebase the scala3 branch an deal > with merge conflicts > > I think there is a lot of benefit to having Scala 3 support and living > with the fact that a couple of connectors don't have Scala 3 support yet. > > > On 2023/06/10 12:56:38 Matthew Benedict de Detrich wrote: > > > while doing it all at once and to also > > > > I meant instead of doing it all at once > > > > On Sat, 10 June 2023, 13:07 Matthew Benedict de Detrich, < > > [email protected]> wrote: > > > > > My preference would delay this as long as it's practical to avoid > merging > > > scala3 into main mainly because we are in no rush to do so. The > unfortunate > > > thing is that there is one module geode which is a bit complicated > when it > > > comes to upgrading to Scala 3 and this is because it uses shapeless > (there > > > is no shapeless for Scala 3, instead the same functionality that > shapeless > > > solves has been mainmailed into Scala 3 language/compiler and > > > https://github.com/typelevel/shapeless-3 is just for automatic > derivation > > > of types which is not relevant here). > > > > > > This was the original intention behind the scala 3 branch, i.e. to > > > piecemeal the scala 3 specific changes to each connector while doing > it all > > > at once and to also to make incomplete PR's that target scala 3 > > > specifically not target main such as > > > https://github.com/apache/incubator-pekko-connectors/pull/160. > > > > > > The annoying thing is that if it wasn't for ASF, this wouldn't be an > > > issue. i.e. ideally we could release the artifacts that we can for > version > > > 1.0.0 and then when scala-3 support is added later to complicated > modules > > > like geode we can just release only the scala 3 artifact for geode > 1.0.0. > > > > > > On Fri, Jun 9, 2023 at 7:48 PM PJ Fanning <[email protected]> > wrote: > > > > > >> Hi everyone, > > >> > > >> NB this email does not affect the Pekko Core RC1 work - it is parallel > > >> work > > >> > > >> We have about 70% of the connectors working with Scala3. Some more > > >> will be ready soon while some others are blocked or time consuming to > > >> fix up. > > >> > > >> Slick, Geode, MongoDB connectors are among those that need major > rewrites. > > >> > > >> Main issue tracking this [1]. See the 'scala3' label to link to the > > >> broken out issues representing the more problematic connectors. > > >> > > >> I would like to merge the 'scala3' branch into 'main' branch now. > > >> > > >> This would mean that we would automatically publish snapshot jars for > > >> the connectors that already work with Scala 3. It would also help to > > >> unblock Scala3 work on pekko-persistence-cassandra [2]. > > >> > > >> > > >> [1] https://github.com/apache/incubator-pekko-connectors/issues/126 > > >> [2] > > >> > https://github.com/apache/incubator-pekko-persistence-cassandra/issues/53 > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [email protected] > > >> For additional commands, e-mail: [email protected] > > >> > > >> > > > > > > -- > > > > > > Matthew de Detrich > > > > > > *Aiven Deutschland GmbH* > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > *m:* +491603708037 > > > > > > *w:* aiven.io *e:* [email protected] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
