I guess my reason for not being a fan of putting JIRA issues in headers is that headers have actual legal weight, and since codebases can last decades those references to JIRA issues could be lost/invalid etc etc. So if it's not clear from the text of the header that Pekko was an extraordinary circumstance (i.e. a hard fork due to a ASF license change to BSL) then I would prefer the text of the custom header to be improved.
Even with that being said, I am getting a nagging feeling that the suggestion implicitly is kind of a red herring. ASF projects shouldn't be willy nilly copying headers from other projects without thinking about it, especially if it's obvious that the header is a custom one. Even Pekko uses the standard ASF header for sources which weren't derived from Akka (see https://github.com/apache/incubator-pekko/blob/main/project/LicenseReport.scala#L1-L16 as an example). Also in context Pekko is nearly one year old and this is the first time someone has complained about this. Granted this may not be a good reason by itself, but from the onset it honestly looks like a single project has made an unwise decision that they shouldn't have. Is there any evidence if this is a common pattern? If so then I guess we can raise another legal ticket confirming an improved text that makes it more clear. On Tue, Sep 5, 2023 at 9:11 PM Christofer Dutz <[email protected]> wrote: > Well ... > > the reason I was suggesting to put it in the header, was that otherwise > someone will see it and either copy it, because it's a lot shorter and > people will like that. Or they will bring up the issue, like I did. > > It doesn't even have to be a link to the issue, just an explanation that > this is a special header that exists for special reasons and should not be > copied. > > Could even be a simple comment underneath the header. > > Putting it in Confluence, would not be much different, as someone will > only find it, if he knows where to look ... just like that Jira ticket. > > Chris > > > On 2023/09/05 17:32:25 Matthew de Detrich wrote: > > > and thanks for the explanation ... admittedly I would expect this to > come > > up quite regularly. > > Possibly worth adding a link to the jira issue to your special custom > > header? > > > > I am somewhat amicable to putting a JIRA ticket in a header mainly > because > > of how out of > > place it is, i.e. I have never seen it before and we are talking about > > headers which have > > legal implications. > > > > Would documenting it in our wiki be enough? > > > > On Tue, Sep 5, 2023 at 6:44 PM Christofer Dutz <[email protected]> wrote: > > > > > Hi all, > > > > > > and thanks for the explanation ... admittedly I would expect this to > come > > > up quite regularly. > > > Possibly worth adding a link to the jira issue to your special custom > > > header? > > > > > > Otherwise I guarantee that you will be having threads like this over > time > > > over and over again ;-) > > > > > > At least I now have some info to take back to the copy-cat-project ;-) > > > > > > Chris > > > > > > On 2023/09/05 16:26:51 Johannes Rudolph wrote: > > > > This has been extensible discussed and was approved on the legal bug > > > > tracker. > > > > > > > > Christofer Dutz <[email protected]> schrieb am Di., 5. Sept. 2023, > 18:13: > > > > > > > > > Hi all, > > > > > > > > > > today I reviewed a PR in another Apache project and commented on > them > > > > > using some none-standard Apache Header. They replied with "But > other > > > > > projects are also doing it that way". So I did a quick search and > > > indeed it > > > > > was only Pekko using invalid apache headers. > > > > > > > > > > Would you please update your source headers to the formal Apache > ones > > > as > > > > > defined here? > > > > > https://www.apache.org/legal/src-headers.html > > > > > > > > > > Thanks, > > > > > Chris > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
