On Wed, 20 Jun 2001, Doug MacEachern wrote:
> On Thu, 21 Jun 2001, Stas Bekman wrote:
>
> > OK, here is the module that handles all the issues discussed today. See
> > the pod section for the docs and test example.
>
> looks good. could we make warnings be yellow like colorgcc?
Of course. In fact the color-map should be reviewed, I didn't give it much
thought. So your suggestions are welcome. The thing to remember is that
users might have terms running with different backgrounds, so somehow we
should make sure that prints will be still seen.
> i also realized that use vars is not required, just can't have the
> our's inside the BEGIN block, this will work:
> --- Apache/TestTrace.pm~ Wed Jun 20 17:42:34 2001
> +++ Apache/TestTrace.pm Wed Jun 20 17:42:43 2001
> @@ -3,7 +3,7 @@
> use strict;
>
> use Exporter ();
> -use vars qw(@Levels @Utils);
> +our (@Levels, @Utils);
Ok.
Another issue that bothers me is the use of globals to control the
behavior of the module ($Level and $LogFH) if somebody forgets to localize
these when overriding it breaks the behavior of this module in other
places. Should we use OOP instead?
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
