On Tue, 11 Sep 2001, Philippe M . Chiasson wrote:
> Here is my second attempt at $r->print(), notice I removed the MP_USE_AP_RWRITE
> since it wasn't needed anymore.
>
> All test still pass with my patch applied.
>
> Here is the patch #2 and I even think it's proprely indented ;-)
looks good. i didn't notice the first time, but why ap_rvprint? since
the function does not exist in apache, just make a modperl specific
mpxs_Apache__RequestRec_print
style is much better, thanks :)
just missing alignment here:
> +static MP_INLINE apr_size_t mpxs_ap_rvprint(pTHX_ I32 items,
> + SV ** MARK, SV ** SP)
and this:
> + if(IoFLUSH(PL_defoutgv)){
should be:
if (...) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
