Doug MacEachern wrote:
> On Thu, 4 Oct 2001, Stas Bekman wrote:
>
>
>>my patch provides this workaround and does work. Is it bad?
>>
>
> your patch does not generate Makefile.PL's it uses DIR, very different.
> are you sure it works? DIR => [] will prevent MakeMaker
> Makefile.PL recursion scanning, so without testing your patch it looks
> like only the docs Makefile.PL's would get run and the rest of modperl-2.0
> Makefile.PL's would be skipped.
Nope, it works exactly as before, plus now we can add any extra
directory which is not in the current dir.
Since init_dirscan is not overridable, just as you said if you specify
the DIR argument, the automatic scan of the immediate sub-dirs won't be
performed. That's exactly I've reproduced this code from the
MM_Unix:init_dirscan, and tacked the distant dir at the end.
my @extra_makefile_dirs = qw(docs/src/api/mod_perl-2.0);
use File::Spec::Functions;
use DirHandle ();
my @mf_dirs = ();
for my $dir (@extra_makefile_dirs,
grep {-d} DirHandle->new('.')->read) {
next if curdir() eq $dir || updir() eq $dir;
next if -l $dir; # no symlinks per MakeMaker
push @mf_dirs, $dir if -f catfile($dir, "Makefile.PL");
}
ModPerl::MM::WriteMakefile(
DIR => \@mf_dirs,
...
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
