Doug MacEachern wrote:
> On Mon, 4 Mar 2002, Stas Bekman wrote:
> 
> 
>>since we use 'our' in the autogenerated .pm files, requiring 5.6.1 is 
>>probably a good idea:
>>
> 
> no need.  .pm's that have a .xs are installed in $version/$arch
> so anybody using < 5.006 would have to try really hard to shoot themselves 
> in the foot here.  the top-level Makefile.PL does 'require 5.006', which 
> should stay since it will compile/run with 5.006.  if you want to add a 
> suggestion to Makefile.PL that minimum 5.6.1 is suggested, that'd be fine.

is this OK? since we already require 5.006, v-strings aren't a problem.

Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.58
diff -u -r1.58 Makefile.PL
--- Makefile.PL 31 Dec 2001 08:45:13 -0000      1.58
+++ Makefile.PL 6 Mar 2002 06:57:25 -0000
@@ -25,6 +25,11 @@
      }
  }

+if ($^V lt v5.6.1) {
+    error "You are running Perl version " . sprintf("%vd", $^V),
+        "We strongly suggest to upgrade to at least 5.6.1";
+}
+
  my $build = Apache::Build->new(init => 1);
  my $code  = ModPerl::Code->new;



-- 


_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:[EMAIL PROTECTED]  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to