Doug MacEachern wrote:
> On 31 Jul 2002 [EMAIL PROTECTED] wrote:
>
>
>>stas 2002/07/31 09:32:40
>>
>> Modified: t/response/TestApache compat2.pm
>> lib/Apache compat.pm
>> . Changes
>> Log:
>> added $r->get_remote_host to compat.pm + test
>
>
> i don't think you greped enough. r->connection->remote_host and
> ap_get_remote_host are not the same. this patch should be backed out.
> and instead figure out why ap_get_remote_host is not being wrapped
> (probably just needs a wrapper).
it failed to create the wrapper because the API included an 'int *'
arg, whose typemap was undefined. Is it safe to use 'int * | PTR'
typemap? I've checked the conversion functions and they seem to do the
right thing:
Index: xs/maps/apache_types.map
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/maps/apache_types.map,v
retrieving revision 1.7
diff -u -r1.7 apache_types.map
--- xs/maps/apache_types.map 26 Mar 2002 01:52:12 -0000 1.7
+++ xs/maps/apache_types.map 12 Aug 2002 08:16:41 -0000
@@ -43,7 +43,7 @@
########## Standard types ##########
int | IV
-int * | UNDEFINED
+int * | PTR
unsigned int | UV
signed int | IV
long | IV
that's said should the XS generator generate a fatal error when an XS
wrapper is not created, because one of the argument's typemap is unknown?
in any case, the automatic wrapper now gets added. But its arguments are:
const char *
ap_get_remote_host(conn, dir_config, type, str_is_ip)
Apache::Connection conn
void * dir_config
int type
int * str_is_ip
should the wrapper accept $r instead of $c (requiring a manual wrapper)?
should we NULL the str_is_ip argument? It seems to me that the Perl
interface should be:
$r->get_remote_host($type);
($type is new to 2.0)
>> --- Changes 21 Jun 2002 22:35:49 -0000 1.29
>> +++ Changes 31 Jul 2002 16:32:40 -0000 1.30
>> @@ -12,6 +12,8 @@
>>
>> =item 1.99_04 - June 21, 2002
>>
>> +added $r->get_remote_host to compat.pm + test [Stas Bekman]
>> +
>
>
> and, um, 1.99_04 was already released. new changes should be under
> 1.99_05-dev.
sorry about that, will fix.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
