Stas Bekman wrote:
Currently, $r->send_http_header can't be called before the response stage, so the 1.0 code won't run out of the box. This is an attempt to solve that problem.can you explain what's going on here? I see that you've made compat.pm's send_http_header() almost a no-op, which looks just fine to me. I would have thought that was sufficient.
I haven't committed it, because I'm not sure whether the following assumption will stand:
- wb->header_parse = MpDirPARSE_HEADERS(dcfg) ? 1 : 0;
+ wb->header_parse = (!r->content_type && MpDirPARSE_HEADERS(dcfg)) ? 1 :
so, what is all the rest of this? can't 2.0 users just rely on the header filter to do the work? if 2.0 users call send_http_header() when they shouldn't, shouldn't we just throw an error instead of appeasing improper use of the API?
or are you talking about legacy 1.0 code running without compat.pm? I guess I don't get what's going on here (not that I have to :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
