[EMAIL PROTECTED] wrote:
randyk 2003/02/19 21:19:14

Modified: lib/ModPerl BuildOptions.pm
Log:
Reviewed by: stas
Revision Changes Path
1.17 +7 -0 modperl-2.0/lib/ModPerl/BuildOptions.pm
Index: BuildOptions.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/ModPerl/BuildOptions.pm,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- BuildOptions.pm 21 May 2002 16:48:29 -0000 1.16
+++ BuildOptions.pm 20 Feb 2003 05:19:14 -0000 1.17
@@ -3,6 +3,7 @@
use strict;
use warnings;
+use Apache::Build ();
my $param_qr = qr([\s=]+);
use constant VERBOSE => 1;
@@ -66,6 +67,12 @@
if($key eq 'MP_APXS') {
$val = File::Spec->canonpath(File::Spec->rel2abs($val));
}
+
+ # MP_AP_PREFIX may not contain spaces
+ if ($key eq 'MP_AP_PREFIX' && Apache::Build::WIN32()) {
+ require Win32;
+ $val = Win32::GetShortPathName($val);
^^^^^^^^^^^
tabs

Randy, please review
http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide
tabs are no-no in 2.0 code, unless this is a code that generates a makefile section.


__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to