Hi Philippe,
Philippe M. Chiasson wrote:
On Wed, 2003-06-18 at 17:19, Steve Hay wrote:Done. Attached.
I've attached a patch for Apache::Reload that makes use of your code to achieve what I'm after. The patch is against the Apache::Reload currently in mp2 cvs. Things to note:
[snip]
Can you instead look at this patch: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=105591352209314&w=2
And integrate that into an mod_perl 1 & 2 Apache::Reload instead? I would rather not have to maintain 2 ever so slightly different versions of Apache::Reload if that can be avoided.
I had to alter the patch that you cited above very slightly: it defers the import of the OK constant until run-time, which made it choke on the bareword OK (since its running under "use strict"). I've therefore pushed the mp1/mp2 conditional stuff inside a BEGIN {} block.
I've also added a couple of extra lines to conditionally setup an undef_func() -- under mp1 it is just Apache::Symbol::undef, under mp2 it will be ModPerl::Util::undef which you suggested in the rest of your mail (below).
The only other thing that I was using from Apache::Symbol was the file2class() function. I've now included that in Apache::Reload itself as module_to_package(), complementing the package_to_module() that it already had.
If this is useful in other places we can add it to ModPerl::Util:: perhaps we should make further subclassing of that namespace.
+use B; +use Devel::Symdump;
Hmm, do these available for perl 5.005_03? Have you tested with that perl version? mp1 has to support perl 5.005_03 I think. Or was it 5.004?
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
