Geoffrey Young wrote:

here is a new patch.



sure, we can fix the internals later. what's important is to get the functionality right asap.


yup.

so I take it you're +1, save the below tweaks?

I haven't tested it, but looks ok, i can test it soonish, if you have a cleaned up version that would be better.


 sub canon_args {
     my $args = shift->{args};
-    my @in   = map { "$_->{type} *$_->{name}" } @$args;
     my @pass = map { $_->{name} } @$args;
+    my @in;
+    foreach my $href (@$args) {
+      push @in, "$href->{type} *$href->{name}"
+        unless $href->{type} eq 'dummy';
+    }
     return wantarray ? ([EMAIL PROTECTED], [EMAIL PROTECTED]) : [EMAIL PROTECTED];
 }



indent 4 please.


it wasn't indented 4 before I got there :)

it's your fault anyways ;)



__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to