Stas Bekman wrote:

Steve Hay wrote:

Hi,

I've been having trouble building (the latest CVS) mp2 with perl 5.8.1 (@21148) -- see this thread on p5p if you want the gory details:

http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2003-09/msg00701.html


The answer seems to be to ensure that mod_perl.so appears before mod_perl.lib in the MODPLER_LIB macro in src/modules/perl/Makefile.modperl.



or did you want to make sure that mod_perl.lib would be the very last one?
most likely this is the case since now we have: $libs{shared} = $libs{dso};

Yep - I agree. Your second patch (below) works fine for me.


- Steve



Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.145
diff -u -r1.145 Build.pm
--- lib/Apache/Build.pm 6 Sep 2003 01:10:18 -0000       1.145
+++ lib/Apache/Build.pm 12 Sep 2003 17:00:07 -0000
@@ -1280,7 +1280,11 @@

my @libs;
for my $type (map { uc } keys %libs) {
- push @libs, $self->{"MODPERL_LIB_$type"} if $self->{"MP_USE_$type"};
+ next unless $self->{"MP_USE_$type"};
+ # on win32 mod_perl.lib must come after mod_perl.so
+ $type eq 'STATIC'
+ ? push @libs, $self->{"MODPERL_LIB_$type"}
+ : unshift @libs, $self->{"MODPERL_LIB_$type"};
}


print $fh $self->canon_make_attr('lib', "@libs");




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to