On Wed, 15 Oct 2003, Steve Hay wrote:
> Attached is a patch to stop this warning being printed every time I run
> "perl Makefile.PL ...":
>
> Use of uninitialized value in concatenation (.) or string at
> lib/ModPerl/BuildOptions.pm line 107, <DATA> line 20.
>
> - Steve
=====================================================================
--- BuildOptions.pm.orig 2003-10-07 19:28:38.000000000 +0100
+++ BuildOptions.pm 2003-10-15 11:43:18.272019200 +0100
@@ -105,7 +105,7 @@
my $fh;
my @files = map { $_ . 'makepl_args.mod_perl2' }
- qw(./ ../ ./. ../.), "$ENV{HOME}/.";
+ qw(./ ../ ./. ../.), (Apache::Build::WIN32() ? () : "$ENV{HOME}/.");
unshift @files, $self->{MP_OPTIONS_FILE} if $self->{MP_OPTIONS_FILE};
for my $file (@files) {
@@ -164,6 +164,8 @@
sub table {
$Table ||= parse_table(\*DATA);
+ close DATA;
+ return $Table;
}
1;
==================================================================
I'm probably one of 3 people in the world who does this,
but I have HOME defined on Win32, exactly because of the
warnings one gets from many packages when it isn't defined.
But I could see where some users may use a Win32 HOME ...
Maybe one should just check to see if $ENV{HOME} is defined,
and if so, use it?
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
